add container Image builds to Makefile and ci #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename Dockerfile to the more universal Containerfile. This name is less specific to docker and more common in the world of docker. Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
37eb379 to
d48b3b7
Compare
With this change, building and publishing a container image (to quay.io) is as easy as running make image-build and make image-push. Some spects of the image (lik registry and tag) can optionally be tweaked with some make variables. Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR adds tooling for building and publishing acontainer image
With this change, building and publishing a container image (to quay.io)
is as easy as running
make image-buildandmake image-push, respectively.Some spects of the image (like registry and tag) can optionally be tweaked with some make variables.
Checklist
Not all of these might apply to your change but the more you are able to check
the easier it will be to get your contribution merged.