build: stop vendoring go modules #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
strange, the pre-commit CI check fails with this message: Error: getCacheEntry failed: <h2>Our services aren't available right now</h2><p>We're working to restore all services as soon as possible. Please check back soon.</p>05uCMaAAAAABAadV/l6Q8SoHNJV6NZnreRE0yRURHRTA1MTEARWRnZQ==I tried a couple of times. Unsure what can be done.. |
Signed-off-by: Michael Adam <obnox@samba.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This change stops the unneeded vendoring of go module:
The marginal benefit of avoiding downloads for building do not outweigh the above disadvantages.
Resolves: #122
Checklist
Not all of these might apply to your change but the more you are able to check
the easier it will be to get your contribution merged.