rules: implement isabling minphony via config #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setting required to empty in the minphony section now disables the minphony rule altogether. Fixes: checkmake#117 Signed-off-by: Michael Adam <obnox@samba.org>
4ea056e to
44580e4
Compare
Collaborator
Author
|
@cavo789, testing this would be great! |
obnoxxx
commented
Jun 11, 2025
Collaborator
Author
obnoxxx
left a comment
There was a problem hiding this comment.
- I tested it thoroughly and it works reliably for me.
- unit test is adjusted and passes.
- manpage is updated
LGTM 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setting required to empty in the minphony section now disables the minphony rule altogether.
Resolves: #117
Checklist
Not all of these might apply to your change but the more you are able to check
the easier it will be to get your contribution merged.