@mrtazz the CI fails on ./checkmake Makefile with the maxbodylength rule for the pizza and coverage targets but that is even the case for plain main. I don't understand yet how this can be the case and previous PRs did not have this problem 🤷🏼

@mrtazz the CI fails on ./checkmake Makefile with the maxbodylength rule for the pizza and coverage targets but that is even the case for plain main. I don't understand yet how this can be the case and previous PRs did not have this problem 🤷🏼

Well, I was not quite right:

• with current main, ./checkmake Mainpasses just fine, but:
• building from this PR locally, it fails like in the CI.

./checkmake  Makefile 
      RULE                 DESCRIPTION             FILE NAME   LINE NUMBER  
                                                                            
  maxbodylength   Target body for "coverage"       Makefile    75           
                  exceeds allowed length of 5                               
                  lines (8).                                                
  maxbodylength   Target body for "pizza"          Makefile            159  
                  exceeds allowed length of 5                               
                  lines (6). 

This confuses me since this PR does not have any diff that would explain this to me.
In particular, it does not change the maxbodylength rule...

@mrtazz the CI fails on ./checkmake Makefile with the maxbodylength rule for the pizza and coverage targets but that is even the case for plain main. I don't understand yet how this can be the case and previous PRs did not have this problem 🤷🏼

Well, I was not quite right:

* with current `main`, `./checkmake Main`passes just fine, but:

* building from this PR locally, it fails like in the CI.

This confuses me since this PR does not have any diff that would explain this to me. In particular, it does not change the maxbodylength rule...

I missed the fact that I accidentally committed the removal of the checkmake.ini file which explains the failure since it overrode the maxBodyLength setting from the default of 5to 8.

Restoring the file has fixed the CI.

added manpage update.

I am currently trying to complete this PR by adding some unit test for the new behavior but still struggling with failures that I need to get rid of before updating.

I am currently trying to complete this PR by adding some unit test for the new behavior but still struggling with failures that I need to get rid of before updating.

added the test to the PR even though I know it is currently failing.
Seeing the failure in the CI might make troubleshooting and fixing it more easy.

while there is still a failure of make testthat needs to be resolved, this PR satisfies the request of issue #113 :

$ cat test.ini
[maxbodylength]
maxBodyLength = 3
[minphony]
required = foo, bar
$ cat test.mk


.PHONY: long
long:
   @echo 1
   @echo 2
   @echo 3
   @echo 4
   @echo 5
   @echo 6
   @echo 7
   @echo 8
   @echo 9

$ make clean checkmake
...
$ ./checkmake --config=./test.ini ./test.mk 
     RULE                 DESCRIPTION             FILE NAME   LINE NUMBER  
                                                                           
 minphony        Missing required phony target    ./test.mk   3            
                 "foo"                                                     
 minphony        Missing required phony target    ./test.mk   3            
                 "bar"                                                     
 maxbodylength   Target body for "long" exceeds   ./test.mk   4            
                 allowed length of 3 lines (9).
$ echo $?
3
$ 

test fixed 😄

updated once more to undo accidentally committed changes to rules/minphony/minphony_test.gothat were done by my editor formatting with gofmt upon saving.

@mrtazz any thoughts about this one? 😉