Merged
Conversation
Just as you can pass a `path` argument to a `Session` (enabling persistency), this will allow the `connect` function to have persistency.
Contributor
Author
|
Don't merge yet, I just realized this change isn't fully working |
Contributor
Author
|
I've updated all the code. Should work but I haven't tested. |
Closed
Member
|
Please add tests for your modification. |
Contributor
Author
|
@auxten I have added a test. It all should work now 👍 |
auxten
reviewed
Mar 20, 2024
Member
|
Fixing some test issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just as you can pass a
pathargument to thedbapi.connect()function (enabling persistency). This will allow similar functionality as theSessionapi already provides, but using the dbapi.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added
pathparameter to dbapiDocumentation entry for user-facing changes
path: the folder path to use for database data on disk.