Enable the line curve in the line annotation #754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: types/options.d.ts
Conflicts: src/types/label.js src/types/line.js
kurkle
reviewed
Sep 28, 2022
Member
kurkle
left a comment
There was a problem hiding this comment.
couple of nits, I think this will be a very nice addition!
Co-authored-by: Jukka Kurkela <jukka.kurkela@gmail.com>
Co-authored-by: Jukka Kurkela <jukka.kurkela@gmail.com>
Conflicts: src/helpers/helpers.chart.js src/types/box.js src/types/line.js
kurkle
previously approved these changes
Jan 26, 2023
Member
|
@stockiNail I'm not merging these, so you can decide the order you want to go. |
kurkle
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is enabling the line curve representation by the line annotation.
It uses quadratic curve and
Path2D.TODO