Move interaction object at top level of plugin options #736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurkle
approved these changes
May 19, 2022
Member
kurkle
left a comment
There was a problem hiding this comment.
Not sure if this has an impact on the resolution of options, but probably not,
Collaborator
Author
I don't think so because interaction can not be set at annotation level, like clip. |
Collaborator
Author
@kurkle I have tested locally (even if I was almost sure) that interaction is falling back to chart options interaction if missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
interactionobject has been moved at top level of plugin options, instead of common object as implemented by PR #630.This is because the
interactionis not configurable at annotation instance but is a plugin configuration, likeclipone.