Replace deprecated String.prototype.substr() #711
Conversation
String.prototype.substr() is deprecated (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr) so we replace it with slice() which isn't deprecated. Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
|
Merged as this was not a breaking change. If we decide to release another minor for v1, the milestone of this pr needs to be updated. |
|
@kurkle I have seen that this PR created a release note 1.4.1 even if tagged as 2.0.0: https://github.com/chartjs/chartjs-plugin-annotation/releases/tag/untagged-e554510da7259acef101 I don't know if this is correct and a normal behavior. |
|
release-drafter determines the version based on version resolver config: chartjs-plugin-annotation/.github/release-drafter.yml Lines 28 to 40 in 67989c8 so unless its a major or minor, its a patch :) it will update after new commits are added. |
|
@kurkle thank you very much for explanation and apologize for this stupid question. I'm still trying to understand how it works all GHA in place for this project. |
String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated.
.substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.