Change enabled to display option in all nodes of annotations #703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Migration should be made easy, so we need to start a migration guide for v2 when we start merging these changes. |
Collaborator
Author
Yeah! What about a specific doc page (in guide section)? it could be the first PR to merge for version 2 and all the others should be adapted in order to add the right documentation about changes. |
Conflicts: src/types/line.js test/fixtures/line/paddingXY.js
kurkle
approved these changes
Apr 6, 2022
Collaborator
Author
|
Thank you very much @kurkle. Slowly but surely I'm going on with the normalization PR, which needs a big rebase! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #594.
This PR normalizes the option to display or not the nodes of the annotations. Use
displayinstead ofenabled.