Workaround for annotation option resolution #629
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #625
This fixes the issue, but leaves the resolution inconsistent (
chart.options.plugins.annotation.annotations[id].someOptionmight resolve to different value than theelement.options.someOption). This only happens in these rare cases though, where annotation id matches a key inoptions.plugins.annotationordefaults.plugins.annotation.Maybe another solution is to change the current fallback of
plugin.annotationto something else (for exampleplugin.annotation.annotationDefaultsor removing it entirely and duplicating the common options in every element (as it mostly actually is now).I'm not entirely happy with this yet, so will create as draft.