-
Notifications
You must be signed in to change notification settings - Fork 12k
Remove destroy hook #10549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove destroy hook #10549
Conversation
|
|
kurkle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs the migration notes
|
Migration guide needs a rebase it seems |
| import { readFileSync } from "fs"; | ||
|
|
||
| const {version, homepage} = JSON.parse(readFileSync('./package.json')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be changed to:
import * as packageJson from './package.json' assert {type: "json"};But then the rollup file needs to be excluded from eslint, not sure what the better/nicer solution is
Might be fixable with extra eslint config: eslint/eslint#15305 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this way is just fine. Import assertions aren't standardized yet and are still at the proposal phase
benmccann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for fixing the failing build for me
|
@kurkle @LeeLenaleee fyi |
|
Interesting ci did not fail on it, will look at it later |
|
@dangreen I don't seen the get the error when runnning EDIT: |
|
@LeeLenaleee run directly |
TODO:
Add note in migration guide after #10010 is merged that has setup for migration guide