Use different branch name as the default#198
Closed
techknowlogick wants to merge 1 commit intocharmbracelet:mainfrom
techknowlogick:patch-1
Closed
Use different branch name as the default#198techknowlogick wants to merge 1 commit intocharmbracelet:mainfrom techknowlogick:patch-1
techknowlogick wants to merge 1 commit intocharmbracelet:mainfrom
techknowlogick:patch-1
Conversation
To align with the default from various other forges (GitHub, GitLab, Gitea, etc..), and the git client itself. I've updated the default branch name for new repos to match.
Contributor
|
Hey @techknowlogick this is definitely something people have expressed interest in. Unfortunately, this is still initializing the config repo with a master branch instead of main. Were you able to get this working on your machine? |
Author
|
Thanks for testing out this PR @bashbunni, I dove deeper into the upstream library and found that it was due to go-git using a default ref, rather than one that soft-serve sets. |
Contributor
|
Ah amazing @techknowlogick thanks for digging into that further and finding the root cause 🙏 |
|
This is solved in |
Author
|
Thanks @decentral1se. I'll close this PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To align with the default from various other forges (GitHub, GitLab, Gitea, etc..), and the git client itself. I've updated the default branch name for new repos to match.