fix: remove doubled error message#39
Merged
caarlos0 merged 1 commit intocharmbracelet:mainfrom Dec 2, 2024
Merged
Conversation
spf13/cobra already handles printing of non-nil error on stderr, the removed print was repeating the same message on stdout after cobra printed both the error and usage. Signed-off-by: Michał Kotowski <dev@mkotowski.dev>
Pull Request Test Coverage Report for Build 12090836108Details
💛 - Coveralls |
Contributor
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! A very minor issue. Unhandled errors are printed twice, once on stderr by cobra and for the second time in
main()to stdout,Useful link describing the behavior of built-in error printing in cobra: https://github.com/spf13/cobra/blob/main/site/content/user_guide.md#error-message-prefix