fix: match display of BEL, ST, DEL with other Ctrl#37
Merged
caarlos0 merged 1 commit intocharmbracelet:mainfrom Dec 2, 2024
Merged
fix: match display of BEL, ST, DEL with other Ctrl#37caarlos0 merged 1 commit intocharmbracelet:mainfrom
caarlos0 merged 1 commit intocharmbracelet:mainfrom
Conversation
Modify BEL, ST, and DEL labeling to match other Ctrl sequences:
- Add missing label for DEL.
- Fix BEL and C1 ST not having their hex code displayed
when not part of a sequence
- Handle ESC \\ (C0 ST)
- Add tests for C0, C1, and misc ASCII (space and DEL)
Signed-off-by: Michał Kotowski <dev@mkotowski.dev>
Pull Request Test Coverage Report for Build 12039709520Details
💛 - Coveralls |
aymanbagabas
approved these changes
Nov 27, 2024
Member
aymanbagabas
left a comment
There was a problem hiding this comment.
Looks good, thank you @mkotowski!
Contributor
|
Thanks @mkotowski ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: This PR should align some minor inconsistencies in how some C0 and C1 characters are displayed.
Modify BEL, ST, and DEL labeling to match other Ctrl sequences:
After changes: