feat: support PM and SOS sequences#31
Merged
caarlos0 merged 1 commit intocharmbracelet:mainfrom Dec 4, 2024
Merged
Conversation
Closed
caarlos0
approved these changes
Nov 23, 2024
Contributor
|
didn't mean to mark it 'ready to review', can't undo it apparently, sorry 😢 |
Contributor
Author
|
@caarlos0 fixed 😉 |
35257cb to
22d9729
Compare
Pull Request Test Coverage Report for Build 12154659882Details
💛 - Coveralls |
caarlos0
approved these changes
Dec 2, 2024
Contributor
caarlos0
left a comment
There was a problem hiding this comment.
lgtm!
can you resolve the merge conflict?
thanks so much! <3
aymanbagabas
approved these changes
Dec 2, 2024
Add support for PM (Privacy Message) and SOS (Start of String) as defined in ECMA-48. Signed-off-by: Michał Kotowski <dev@mkotowski.dev>
22d9729 to
7b3d763
Compare
Contributor
Author
|
@caarlos0 done, rebased on current main 🙂 |
Contributor
|
Thank you @mkotowski! <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for PM (Privacy Message) and SOS (Start of String) as defined in ECMA-48.
Colors for PM were chosen more or less arbitrarily. Colors of SOS are set identical to Text since SOS is practically unused (spare more appealing/distinct colors for eventual future stuff) and is designed to carry special class of strings, so it is somewhat close semantically to normal text.
Since both do not have any implementations (that I am aware of) with sub-parameters, their handling was placed directly in
process, instead as part of handlers' maps.Most terminals simply do not render text enclosed by PM or SOS. GNU
screenuses PM for its message line facility.Example output: