Merged
Conversation
Adds a `repoRecentReleases` command that fetches the latest releases for a given repository. Reference: muesli#84
Pull Request Test Coverage Report for Build 9875532248Details
💛 - Coveralls |
caarlos0
reviewed
Jul 10, 2024
caarlos0
reviewed
Jul 10, 2024
caarlos0
reviewed
Jul 10, 2024
|
Looks great! I agree with what Carlos said, but don't have anything to point out beyond that :) |
caarlos0
reviewed
Jul 10, 2024
| } | ||
|
|
||
| func repoRecentReleases(owner, name string, count int) []Release { | ||
| var releases []Release |
There was a problem hiding this comment.
beware though, the api might not actually reply with that many repos...
probably better to move this line a couple of lines down and do
releases := make([]Release, len(repoRecentReleasesQuery.Repository.Releases.Nodes))Co-authored-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Co-authored-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Co-authored-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
bashbunni
approved these changes
Jul 12, 2024
bashbunni
left a comment
There was a problem hiding this comment.
Works great, just tested it locally with my draft branch 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
repoRecentReleasescommand that fetches the latest releases for a given repository.Reference: muesli#84