Skip to content

fix: some of the lint issues#909

Merged
caarlos0 merged 2 commits intomainfrom
lint
May 30, 2025
Merged

fix: some of the lint issues#909
caarlos0 merged 2 commits intomainfrom
lint

Conversation

@caarlos0
Copy link
Copy Markdown
Contributor

also removed some unused code.

@caarlos0 caarlos0 self-assigned this May 30, 2025
@caarlos0 caarlos0 requested a review from a team as a code owner May 30, 2025 13:17
@caarlos0 caarlos0 requested review from kujtimiihoxha and removed request for a team May 30, 2025 13:18
@caarlos0 caarlos0 added the enhancement New feature or request label May 30, 2025
@caarlos0 caarlos0 requested review from a team and Copilot May 30, 2025 13:18
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses several lint issues and cleans up unused code.

  • Adds or updates package-level comments across multiple files.
  • Refactors constant declarations and updates linter annotations on error handling and performance hints.
  • Removes unused code from internal utility, logging, and stack packages.

Reviewed Changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.

Show a summary per file
File Description
version/command.go Added package documentation comment.
style/spacing.go Consolidated constant declarations into a const block.
spin/pty.go Added nolint annotations (wrapcheck) on error returns.
pager/search.go Replaced utils.LipglossPadding with a local lipglossPadding function and removed outdated nolint comments.
pager/pager.go Removed nolint annotation from text rendering.
man/command.go Added package documentation comment.
main.go Added package documentation comment.
log/options.go Removed nolint comment from the LevelStyle field.
log/command.go Updated error handling with nolint annotations.
internal/utils/utils.go Removed unused utility functions.
internal/stack/stack.go Removed unused stack implementation.
internal/log/log.go Removed obsolete log error function.
internal/files/files.go Minor formatting update.
internal/exit/exit.go Adjusted import formatting.
internal/decode/align.go Added package documentation comment.
cursor/cursor.go Added package documentation comment.
completion/bash.go Added bash completion generator documentation.
choose/command.go Added nolint comment for prealloc on the labels slice.

@caarlos0 caarlos0 merged commit 817c4bd into main May 30, 2025
16 checks passed
@caarlos0 caarlos0 deleted the lint branch May 30, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants