Allow to show spinner on non tty output devices#812
Closed
ctn-malone wants to merge 3 commits intocharmbracelet:mainfrom
ctn-malone:refactor-allow-to-show-spinner-on-non-tty
Closed
Allow to show spinner on non tty output devices#812ctn-malone wants to merge 3 commits intocharmbracelet:mainfrom ctn-malone:refactor-allow-to-show-spinner-on-non-tty
ctn-malone wants to merge 3 commits intocharmbracelet:mainfrom
ctn-malone:refactor-allow-to-show-spinner-on-non-tty
Conversation
Contributor
|
hmm, I think the problem there is that we should have checked for stderr instead of stdout, let me give it a better look |
Contributor
|
can you try #813? |
ccoVeille
approved these changes
Jan 21, 2025
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
--show-spinneroption to work around the fact that by default, spinner won't be shown when output device is not a TTY (ie: redirected or piped) on version0.15.0(introduced in cf2da64)Examples
While flag name may be a bit confusing, I think such option may be useful and would fix some issues such as #803