Skip to content

fix(pager): do not strip ansi sequences#754

Merged
caarlos0 merged 1 commit intomainfrom
strip-input
Dec 9, 2024
Merged

fix(pager): do not strip ansi sequences#754
caarlos0 merged 1 commit intomainfrom
strip-input

Conversation

@caarlos0
Copy link
Copy Markdown
Contributor

@caarlos0 caarlos0 commented Dec 9, 2024

it makes sense to strip everywhere else, but I think the pager is the exception.

closes #509

@bashbunni
Copy link
Copy Markdown
Contributor

I think this makes sense too. Existing ANSI sequences wouldn't affect usability the same way it does in other components

@caarlos0 caarlos0 merged commit 2939e51 into main Dec 9, 2024
@caarlos0 caarlos0 deleted the strip-input branch December 9, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Highlighting doesn't seem to work when combining glow with gum pager

2 participants