fix(confirm) --timeout was ignored, now works as documented#697
Merged
caarlos0 merged 2 commits intocharmbracelet:mainfrom Nov 15, 2024
Merged
Conversation
41ec719 to
049c7b9
Compare
049c7b9 to
cf0a8d1
Compare
--timeout was ignored, now works as documented
caarlos0
approved these changes
Nov 15, 2024
Contributor
caarlos0
left a comment
There was a problem hiding this comment.
just a couple of small things, looks good otherwise
thank so much for the PR!
Contributor
Author
Nice suggestions, thanks. I've added them. |
Contributor
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #698.
Relevant excerpts from
gum confirm --helpChanges
.WithTimeout(o.Timeout)in theconfirmcommand'shuh.NewForm()chain underconfirm.Run()errIsValidTimeout(error) boolmethod toconfirm.Optionsto facilitate safely ignoring the timeout error returned in the course of theRun()context expiring due to timeouterrIsValidTimeoutDemos
Before: doesn't time out without outside help
Note that five seconds elapse here before
timeoutkillsgum, returning a nonzero exit code.After: times out as expected
Times out in ~1 second as desired.
Also works with
GUM_CONFIRM_TIMEOUT.