Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes background detection logic into a new helper, refactors theme initialization in Execute, and cleans up example usage flags.
- Introduces
mustColorschemeto apply a default theme only when needed. - Updates
Executeinfang.goto usemustColorschemefor help and error styling. - Removes explicit
WithoutManpageandWithoutCompletionscalls from the example.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| theme.go | Adds mustColorscheme function and imports os and term. |
| fang.go | Refactors theme logic in Execute to use the new helper. |
| example/main.go | Removes unnecessary theme-related option calls. |
Comments suppressed due to low confidence (1)
theme.go:89
- [nitpick] The function name
mustColorschemeis not idiomatic Go; consider renaming tomustColorSchemeto follow camelCase conventions for multi-word names.
func mustColorscheme(cs *ColorScheme) ColorScheme {
| } | ||
| var isDark bool | ||
| if term.IsTerminal(os.Stdout.Fd()) { | ||
| isDark = lipgloss.HasDarkBackground(os.Stdin, os.Stderr) |
There was a problem hiding this comment.
Using os.Stdin and os.Stderr for HasDarkBackground may mismatch the terminal check on os.Stdout. Consider passing the same output stream (e.g., os.Stdout) to ensure consistent background detection.
Suggested change
| isDark = lipgloss.HasDarkBackground(os.Stdin, os.Stderr) | |
| isDark = lipgloss.HasDarkBackground(os.Stdout) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs #35