Conversation
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new color scheme feature by extending the theme structure with new color fields and redefining default themes for dark and light modes. The changes include updates to the Theme struct (adding fields like Program, Command, and QuotedString), adjustments in theme handling in the settings, and updates to style rendering for command and quoted string display.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| theme.go | Adds new color fields to Theme and defines DefaultThemeDark and DefaultThemeLight (with a minor comment mislabel). |
| serpentine.go | Updates the settings to use a pointer for theme and adds a nil check for theme assignment. |
| help.go | Adjusts style rendering in usage and error output, including handling for quoted strings. |
| go.mod | Adds a new dependency for the charmtone package. |
| example/main.go | Provides usage examples including quoted-string examples. |
Comments suppressed due to low confidence (1)
theme.go:51
- The comment on line 51 appears to be mislabelled as it precedes the definition of DefaultThemeLight. Please update it to correctly describe the default light theme.
// DefaultThemeDark is the default colorscheme.
meowgorithm
approved these changes
Jun 8, 2025
Member
meowgorithm
left a comment
There was a problem hiding this comment.
LGTM. I have some small edits in another PR, so let's merge that one first. I'll update images separately.
* chore: rename package to fang * fix: trim extra lines above commands and flags headers * chore: capitalize README.md file * chore: use Charple for light theme headers * chore: example copy edits
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.