fix(key): invert the control loop#569
Merged
muesli merged 1 commit intocharmbracelet:masterfrom Jun 20, 2023
Merged
Conversation
3 tasks
45575f6 to
d7ad9b0
Compare
This was referenced Jan 7, 2023
Merged
Contributor
Author
|
@muesli this is ready again. |
Instead of reading messages in an array and then sending them into a channel, this version of key.go writes to the channel directly.
d7ad9b0 to
4cc032b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit from #568.
This is the control flow change discussed in #511 (comment)
cc @muesli