Skip to content

feat: use Termenv.Output to write to tty#455

Merged
muesli merged 1 commit intomasterfrom
termenv-output
Sep 27, 2022
Merged

feat: use Termenv.Output to write to tty#455
muesli merged 1 commit intomasterfrom
termenv-output

Conversation

@muesli
Copy link
Copy Markdown
Contributor

@muesli muesli commented Sep 22, 2022 •
edited
Loading

  • Uses a termenv.Output to manage writing to outputs
  • Enables us to use arbitrary output devices with color detection
  • Prevents concurrent output access from lipgloss (depending on its next branch, to be merged)
  • Removes code duplication (ANSI screen handling, Windows console) with termenv

Fixes #420, #172, #206, #302.

@muesli muesli force-pushed the termenv-output branch 2 times, most recently from 00bec7a to c9b0176 Compare September 22, 2022 09:06
@muesli muesli requested a review from meowgorithm September 22, 2022 09:09
@meowgorithm meowgorithm self-requested a review September 27, 2022 00:15
@muesli muesli merged commit 6c449e5 into master Sep 27, 2022
@muesli muesli deleted the termenv-output branch September 27, 2022 00:49
@muesli muesli mentioned this pull request Sep 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meowgorithm meowgorithm Awaiting requested review from meowgorithm

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tea and termenv do not honor WithOutput properly

2 participants

@muesli @meowgorithm