Skip to content

fix: check if os.Stdin is a terminal before opening the TTY#1596

Merged
aymanbagabas merged 1 commit into
mainfrom
default-input-tty
Feb 26, 2026
Merged

fix: check if os.Stdin is a terminal before opening the TTY#1596
aymanbagabas merged 1 commit into
mainfrom
default-input-tty

Conversation

@aymanbagabas

Copy link
Copy Markdown
Contributor

This change checks if os.Stdin is a terminal before attempting to open the TTY for input. If os.Stdin is not a terminal, it will proceed to open the TTY as before.

Fixes: #1595

This change checks if os.Stdin is a terminal before attempting to open
the TTY for input. If os.Stdin is not a terminal, it will proceed to
open the TTY as before.

Fixes: #1595
@codecov

codecov Bot commented Feb 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.09%. Comparing base (c751374) to head (9fa4d1b).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
tea.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1596      +/-   ##
==========================================
- Coverage   56.18%   56.09%   -0.09%     
==========================================
  Files          25       25              
  Lines        1285     1287       +2     
==========================================
  Hits          722      722              
- Misses        479      481       +2     
  Partials       84       84              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@robin-samuel

Copy link
Copy Markdown
Contributor

Fixes the issue for me!

@aymanbagabas aymanbagabas merged commit 66b7abd into main Feb 26, 2026
38 of 40 checks passed
@aymanbagabas aymanbagabas deleted the default-input-tty branch February 26, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v2: Missing WindowSizeMsg on windows systems

4 participants