Make auth backend name configurable#151
Conversation
README.md
Outdated
| port, separated with a ':'. Cannot be combined with | ||
| either VAULT_PORT or VAULT_HOST | ||
| --auth-backend AUTH_BACKEND | ||
| Name of Vault authentication backend.Defaults to |
README.md
Outdated
| --auth-backend AUTH_BACKEND | ||
| Name of Vault authentication backend.Defaults to | ||
| 'kubernetes' or 'github' depending on the type of | ||
| thechosen authentication method. Also configurable |
There was a problem hiding this comment.
These missing spaces stem from the missing spaces in the string concatenation at https://github.com/channable/vaultenv/pull/151/files#diff-1a5d6b4436af44266b8d28b7df447ac4de73108f23a314c7e25512456552c915R611-R613.
Riscky
left a comment
There was a problem hiding this comment.
Thanks for the PR!
We need to change the default, otherwise this LGTM
README.md
Outdated
| --auth-backend AUTH_BACKEND | ||
| Name of Vault authentication backend.Defaults to | ||
| 'kubernetes' or 'github' depending on the type of | ||
| thechosen authentication method. Also configurable |
There was a problem hiding this comment.
These missing spaces stem from the missing spaces in the string concatenation at https://github.com/channable/vaultenv/pull/151/files#diff-1a5d6b4436af44266b8d28b7df447ac4de73108f23a314c7e25512456552c915R611-R613.
src/Config.hs
Outdated
| <> help ("Name of Vault authentication backend." | ||
| ++ "Defaults to 'kubernetes' or 'github' depending on the type of the" |
There was a problem hiding this comment.
The lack of spaces at the end of these strings cause the thing that @ig11987 pointed out in the readme.
084489a to
b1ab447
Compare
Allows users to specify the name of their authentication backend if it's different than the default one. Co-authored-by: Ruud van Asseldonk <dev@veniogames.com>
b1ab447 to
bf03b77
Compare
|
For us to be able to print the authentication backend value, as @ruuda suggested, we first need for it to be available when the config is built, so I moved the logic to that stage. |
Riscky
left a comment
There was a problem hiding this comment.
LGTM
I'll draft a release tomorrow
|
@OpsBotPrime merge |
|
Rebased as bf03b77, waiting for CI … |
|
CI job 🟡 started. |
Allows users to specify the name of their authentication backend if it's different than the default one.
Closes #150