Allow overwriting over environment variables#135
Merged
OpsBotPrime merged 1 commit intomasterfrom Jun 29, 2023
Merged
Conversation
fatho
requested changes
Jun 26, 2023
Member
fatho
left a comment
There was a problem hiding this comment.
Implementation-wise, it's fine, but I think the interface could be made clearer
fatho
reviewed
Jun 26, 2023
Contributor
Author
|
@OpsBotPrime merge |
Contributor
|
Pull request approved for merge by @joris-burgers, rebasing now. |
Allow us to overwrite the duplicate variables error with a new flag. When enabling this flag, we don't error on duplicate variables, but instead take the ones from the environment already specified.
Contributor
|
Rebased as 77080d2, waiting for CI … |
Contributor
|
CI job 🟡 started. |
50ec3e5 to
77080d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #134
Allow us to overwrite the duplicate variables error with a new flag. When enabling this flag, we don't error on duplicate variables, but instead take the ones from the environment already specified.