Merged
Conversation
Without this, Nix clears the environment, and then the VAULT_* variables that are set by integration_test.sh do not get propagated properly. Also, use the localhost ip instead of "localhost", because for some reason, "localhost" fails to resolve on my machine.
Contributor
Author
|
Would be good to also run these on CI, but this is difficult for me to add because Semaphore doesn’t seem to run on pull requests that I open. |
Member
Hi! I've enabled "approval mode" for Semaphore now, so the CI should run if we comment the following on a PR: /sem-approve |
Member
|
Reopening this PR to make it actually work. |
Member
|
/sem-approve |
maartenberg
approved these changes
Oct 14, 2021
Member
|
@OpsBotPrime merge |
Member
| @OpsBotPrime driemaal is scheepsrecht |
Contributor
|
Pull request approved for merge by @maartenberg, rebasing now. |
Contributor
|
Rebased as fb2de1f, waiting for CI … |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was unable to run the integration tests, for a few reasons:
vault secrets disablefails withWhen I change
localhostto127.0.0.1this error goes away.The
VAULT_*variables set inintegration_test.shdo not propagate into Vaultenv when Stack uses Nix; it clears the environment, unless we pass--no-nix-pure.Python 3.7 was hard-coded. Add Python to the Nix development environment instead.
In the Python integration test,
subprocess.runwithenvset lost the originalPATH, and whenvaultis taken from the Nix store, we need to preserve thatPATH.With these changes, I can run the integration tests, and they all pass.