skip testing branch preemptive deletion
#173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #134, we transitioned from testing on `testing/<id>` instead of just `testing`. In order to maintain backwards compatibility, we had to delete `testing` every time we created a new `testing/<id>` branch. That has been a month ago, and most projects that use Hoff should have had at least one PR triggering the deletion of `testing`. So we should remove this code that tries deletion every time. We currently see the following in the logs every time we merge: ```haskell Aug 18 13:37:12 hoff hoff[4321]: [Warn] error: git push -d failed. Reason: error: unable to delete 'testing': remote ref does not exist Aug 18 13:37:29 hoff hoff[4321]: error: failed to push some refs to 'git@github.com:<org>/<repo>.git' ``` This should get rid of entries like the above.
testing branch preemptive deletion
4 tasks
alter2000
approved these changes
Aug 23, 2022
alter2000
left a comment
There was a problem hiding this comment.
█ ▒███▒███████ █▒ ▒█
█ ░█▒ ░█ █ ██ ██
█ █▒ █ ██░░██
█ █ █ █▒▓▓▒█
█ █ ██ █ █ ██ █
█ █ █ █ █ █▓ █
█ █▒ █ █ █ █
█ ▒█░ ░█ █ █ █
██████ ▒███▒ █ █ █
Author
|
@alter2000 Thanks for the speedy review. 😄 @OpsBotPrime merge |
|
Pull request approved for merge by @rudymatela, rebasing now. |
|
Rebased as 7d58a61, waiting for CI … |
|
CI job started. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #165
In #134, we transitioned from testing on
testing/<id>instead of justtesting. In order to maintain backwards compatibility, we had to deletetestingevery time we created a newtesting/<id>branch.That has been a month ago, and most projects that use Hoff should have had at
least one PR triggering the deletion of
testing. So we should remove thiscode that tries deletion every time.
We currently see the following in the logs every time we merge:
This should get rid of entries like the above.