Test comments looping back from GitHub #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
301c706 to
9af294a
Compare
alex-mckenna
approved these changes
Jul 22, 2022
alex-mckenna
left a comment
There was a problem hiding this comment.
Looks good to me, good idea to run it through CI with the known failing version 👍
ReinierMaas
approved these changes
Jul 22, 2022
ReinierMaas
left a comment
There was a problem hiding this comment.
LGTM! Thanks for adding this test case and displaying the failure on the buggy version.
Author
|
@alex-mckenna @ReinierMaas, thanks for the review. @OpsBotPrime merge on Friday |
|
Pull request approved for merge by @rudymatela, rebasing now. |
|
Rebased as 9af294a, waiting for CI … |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test comments looping back from GitHub.
Whenever Hoff posts a comment on GitHub, it is notified back by GitHub that that a new comment has been posted. This makes it so that a test now has this behaviour.
This would have detected the issue with v0.25.7 where Hoff got stuck in an infinite loop. Please see #140 which applies these tests on top of the buggy version.