Fixed an issue with failing to parse changesets containing Windows newlines#462
Merged
Fixed an issue with failing to parse changesets containing Windows newlines#462
Conversation
🦋 Changeset detectedLatest commit: 804c7f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Andarist
commented
Sep 30, 2020
| summary: "" | ||
| }); | ||
| }); | ||
| it("should be fine if the frontmatter is followed by a whitespace on the same line", () => { |
Member
Author
There was a problem hiding this comment.
I've recognized this as a separate issue and fixed it first but it seems that the fix for it has also immediately resolved the Windows issue. This makes sense when I look at this regex now - can't find a situation when \r\n would not be covered correctly right now - please recheck though if anything pops into your mind.
emmatown
approved these changes
Sep 30, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe that it fixes #461