Allow private packages to be included in changesets#420
Closed
JakeGinnivan wants to merge 1 commit intochangesets:mainfrom
Closed
Allow private packages to be included in changesets#420JakeGinnivan wants to merge 1 commit intochangesets:mainfrom
JakeGinnivan wants to merge 1 commit intochangesets:mainfrom
Conversation
|
Hooray! All contributors have signed the CLA. |
💥 No ChangesetLatest commit: 353afc2 Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
emmatown
reviewed
Aug 10, 2020
|
|
||
| for (let privatePkg of privatePackages) { | ||
| const tagName = `${privatePkg.packageJson.name}@${privatePkg.packageJson.version}`; | ||
| const isMissingTag = !(await tagExists(tagName)); |
Member
There was a problem hiding this comment.
Could you change this so these calls happen in parallel?
|
FYI I've made an attempt at reviving this functionality in #569 @JakeGinnivan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my solution to #399. I'm currently using this approach in 2 repos and it's working reasonably well right now.
When used in conjunction with the github action this is what happens:
PRs merge to master, that deploys dev. Then a 'Deploy to prod' PR is opened. It includes NPM packages and also private projects with changelogs.
Its a pretty small change which opens up a bunch of cool scenarios