Skip to content

eslint followup 2 - prefer-const#1963

Merged
bluwy merged 7 commits intochangesets:nextfrom
beeequeue:eslint-followup/2-const
May 5, 2026
Merged

eslint followup 2 - prefer-const#1963
bluwy merged 7 commits intochangesets:nextfrom
beeequeue:eslint-followup/2-const

Conversation

@beeequeue
Copy link
Copy Markdown

@beeequeue beeequeue commented May 4, 2026 •
edited
Loading

converts all lets to consts that can be

also fixes all tests that were broken on windows

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 4, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 206e731

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@beeequeue beeequeue changed the title eslint followup #2 - prefer-const eslint followup 2 - prefer-const May 4, 2026
@beeequeue beeequeue requested review from Andarist and bluwy May 4, 2026 17:14
@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 91.00529% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.88%. Comparing base (07278a7) to head (206e731).

Files with missing lines Patch % Lines
packages/cli/src/commands/publish/npm-utils.ts 0.00% 6 Missing and 1 partial ⚠️
packages/cli/src/commands/add/createChangeset.ts 60.00% 4 Missing ⚠️
packages/assemble-release-plan/src/index.ts 89.47% 2 Missing ⚠️
packages/changelog-github/src/index.ts 75.00% 1 Missing ⚠️
packages/config/src/index.ts 95.45% 1 Missing ⚠️
packages/git/src/index.ts 75.00% 1 Missing ⚠️
packages/release-utils/src/readChangesetState.ts 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #1963      +/-   ##
==========================================
- Coverage   81.93%   81.88%   -0.05%     
==========================================
  Files          54       54              
  Lines        2452     2457       +5     
  Branches      718      721       +3     
==========================================
+ Hits         2009     2012       +3     
- Misses        400      402       +2     
  Partials       43       43

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bluwy bluwy merged commit f220fc7 into changesets:next May 5, 2026
10 checks passed
@marcalexiei marcalexiei mentioned this pull request May 5, 2026
Merged
@beeequeue beeequeue deleted the eslint-followup/2-const branch May 5, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bluwy bluwy bluwy approved these changes

@Andarist Andarist Awaiting requested review from Andarist

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@beeequeue @bluwy