Replace release-utils markdown parsing with regex#1962
Conversation
🦋 Changeset detectedLatest commit: c4039bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #1962 +/- ##
==========================================
- Coverage 81.95% 81.89% -0.07%
==========================================
Files 54 54
Lines 2461 2463 +2
Branches 718 717 -1
==========================================
Hits 2017 2017
- Misses 401 403 +2
Partials 43 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
i would prefer using md4x if it doesn't have any major downsides, just to keep our code simpler it would most likely be easier to work with if we add stuff like the semantic change types idea |
|
It's really not any more complex, just different ways of extracting the data we want. If the semantic change idea is easier to work as an AST, then it can always resort to that later. |
|
I don't think it's great to keep large files for the tests, but I just manually tested with our changelog and Svelte's changelog and they all work correctly though |
|
we could zstd compress them :^) but that's good enough for me |
|
I'm going to merge this in. Happy to revert if we have concerns or if people are hitting issues with this. |
And remove the
mdast-*packages. This should also be more efficient as it doesn't have to parse or iterate through the entire changelog text.It's probably bad rep to use regex to parse but I think this should work fine and could try.