eslint update followup 1 & allow custom functions to be sync#1961
Merged
bluwy merged 5 commits intochangesets:nextfrom May 5, 2026
Merged
eslint update followup 1 & allow custom functions to be sync#1961bluwy merged 5 commits intochangesets:nextfrom
bluwy merged 5 commits intochangesets:nextfrom
Conversation
part of enabling and fixing `@typescript-eslint/require-await`
🦋 Changeset detectedLatest commit: 9d8995e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #1961 +/- ##
==========================================
- Coverage 81.95% 81.93% -0.03%
==========================================
Files 54 54
Lines 2455 2452 -3
Branches 718 719 +1
==========================================
- Hits 2012 2009 -3
Misses 400 400
Partials 43 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Andarist
reviewed
May 4, 2026
Andarist
reviewed
May 4, 2026
Andarist
approved these changes
May 4, 2026
Member
Andarist
left a comment
There was a problem hiding this comment.
This has some CI issues - but the change is fine so I'm stamping it preemptively
bluwy
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up to #1876
the only functional change here is allowing sync functions in
CommitFunctionsandChangelogFunctions.async is still supported, but the default functions are now sync which could be a breaking change which is why i marked them as
major