Remove support for experimental useCalculatedVersionForSnapshots#1652
Remove support for experimental useCalculatedVersionForSnapshots#1652
Conversation
🦋 Changeset detectedLatest commit: 00c7225 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #1652 +/- ##
==========================================
- Coverage 82.61% 81.85% -0.77%
==========================================
Files 54 54
Lines 2422 2441 +19
Branches 718 716 -2
==========================================
- Hits 2001 1998 -3
- Misses 379 401 +22
Partials 42 42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| useCalculatedVersion: ( | ||
| config.___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH as any | ||
| ).useCalculatedVersionForSnapshots, | ||
| useCalculatedVersion: false, |
There was a problem hiding this comment.
There is a TODO comment above this declaration that could be done now (in this PR) - if I'm reading things correctly
There was a problem hiding this comment.
IIUC it mentions changing the parameter type to be stricter so we don't have to refine it, so I think it would be a separate breaking change (if I understand correctly too).
I think it may be best tackled in another PR though which I can follow up later
There was a problem hiding this comment.
It's only refined to handle both the old and new formats of snapshot.useCalculatedVersion. Given this PR removed the legacy format - I'd say it would be appropriate to handle this TODO here
There was a problem hiding this comment.
I'm a bit confused but why didn't it refine if config.snapshot was passed then? From #914 it seems that it's to prevent a breaking change if snapshot wasn't pass with different versions installed.
The change for this is to make the config.snapshot non-optional, and the snapshot parameter stricter. And that feels like a different breaking change and out of scope of this PR which addresses useCalculatedVersionForSnapshots only.
|
@Andarist can we handle the TODO from your last review separately? I'd prefer to get this in first. |
It was deprecated in favor of
snapshot.useCalculatedVersion