fix(config): validate prettier option#1590
Merged
Andarist merged 6 commits intochangesets:mainfrom Feb 20, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: f47cc3c The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1590 +/- ##
==========================================
+ Coverage 80.94% 81.16% +0.22%
==========================================
Files 54 54
Lines 2241 2241
Branches 669 674 +5
==========================================
+ Hits 1814 1819 +5
+ Misses 422 417 -5
Partials 5 5 ☔ View full report in Codecov by Sentry. |
freddielaycock
approved these changes
Feb 18, 2025
Member
|
@bennypowers could you add a test case for this? preferably one testing it e2e in the CLI |
Contributor
Author
|
I'll take a look at e2e tests |
Contributor
Author
|
I wrote some tests which look ok to me, but don't appear to actually test the config file. Not sure where I'm going wrong here :/ |
This was referenced Feb 20, 2025
Andarist
reviewed
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1593