Replace meow with mri#1392
Merged
Andarist merged 2 commits intochangesets:mainfrom Jun 24, 2024
bluwy:mri
Merged
Conversation
🦋 Changeset detectedLatest commit: 98d7759 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1392 +/- ##
=======================================
Coverage 80.95% 80.95%
=======================================
Files 54 54
Lines 2211 2211
Branches 657 656 -1
=======================================
Hits 1790 1790
Misses 417 417
Partials 4 4 ☔ View full report in Codecov by Sentry. |
Merged
This was referenced Aug 8, 2024
This was referenced Oct 5, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
meowv6 has 62 transitive dependencies and it would be nice to avoid them in a CLI. While we could also upgrade tomeowv13, which has 0 deps (because bundled), it has a higher nodejs version restriction. Also, the CLI here isn't usingmeowto its fullest potential, only relying on its help message logging and argument parsing.In this PR, I refactored to use
mrifor argument parsing only. I've tested the CLI calls manually to prevent any syntax regressions.