Skip to content

fix: throw error on unrecognized type#1331

Open
unional wants to merge 1 commit intochangesets:mainfrom
unional:patch-1
Open

fix: throw error on unrecognized type#1331
unional wants to merge 1 commit intochangesets:mainfrom
unional:patch-1

Conversation

@unional
Copy link
Copy Markdown

@unional unional commented Mar 22, 2024

fixes #1301

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 22, 2024

⚠️ No Changeset found

Latest commit: 4a5bacb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@bluwy
Copy link
Copy Markdown
Member

bluwy commented Oct 8, 2024

I wonder if we should do the fix in this function instead:

export default function parseChangesetFile(contents: string): {

The loaded yaml isn't being validated, which it probably should? At least it isn't respecting the types. Or I could be wrong.

Breaking-change-wise, I guess it technically is since someone could rely on the non-validation 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot read properties of undefined (reading 'push')

2 participants