Upgrade manypkg/get-packages by elliot-nelson · Pull Request #1069 · changesets/changesets

elliot-nelson · 2023-01-27T20:16:07Z

SUMMARY

Upgrade to latest major release of @manypkg/get-packages
This includes the reorganized @manypkg/tools collection

DETAILS

Adjust various call points and checks to reflect the updated interface of get-packages.
Code paths that check for specific tools can use tool.type instead of tool.
Code paths that must create a tool (mostly unit tests) now import @manypkg/tools so they can use prefab tool implementations. (It's not required -- you could define your own fake monorepo implementation inline for testing -- but this was the easiest way to confirm that the previous intent was still being met.)

For the most part, there should be no functional changes in this PR except those introduced in the latest version of get-packages:

Rush monorepos are now parsed correctly and work for changeset creation + changeset version commands.
Bolt monorepos are no longer supported.

Note that for Rush specifically, changeset publish needs more work, which will come in a separate dedicated PR.

TESTING

Updated existing unit tests
Verified behavior in local Rush monorepo

changeset-bot · 2023-01-27T20:16:11Z

⚠️ No Changeset found

Latest commit: 07c516b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

codesandbox-ci · 2023-01-27T20:16:34Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 07c516b:

Sandbox	Source
Vanilla	Configuration

Andarist · 2023-01-27T20:37:07Z

  let releasedPackages: Package[] = [];

-  if (tool !== "root") {
+  if (tool.type !== "root") {


We will have to also update this in changesets/action:
https://github.com/changesets/action/blob/595655c3eae7136ff5ba18200406898904362926/src/run.ts#L95

changesets/action should be built on top of @changesets/release-utils - but this wasn't yet unified.

Got it, will check it out.

As an aside, could be interesting to explore moving the source code for actions into the monorepo as a package. We've had some success with this with action collections in monorepos.

The "publish" command, instead of being NPM-based, becomes git-based: you build the action, bundle dist up into a single file (with @vercel/ncc or your favorite equivalent), and then your calculated version (e.g. 4.1.0) becomes the branch name... you push the files directly into branch v4.1.0 in the target repo, changesets/action.

(To follow GH conventions, you usually also have branches for major versions, so you follow it up by chopping off and fast-forwarding, e.g. git checkout v4 && git reset --hard v4.1.0 && git push -f in the target repo.)

This also brings up the whole question of "well... what if I wanted changesets to manage publishing all my actions, using this alternate publishing scheme?". That's a question we never really dug into Rush but I've always thought it would be cool if it was as simple as:

[ { "packageName": "@example/core", "shouldPublish": true, "publishMethod": "pnpm" }, { "packageName": "@example/custom-action", "shouldPublish": true, "publishMethod": "github-action", "targetRepo": "example-company/custom-action" } ]

And then you'd just "publish all" and everything is done for you.

Ye, it would be kinda neat if the changesets/action repo could just become a publish target.

Andarist · 2023-01-27T20:39:50Z

  snapshot?: string | boolean
 ) {
-  let cwd = packages.root.dir;
+  let cwd = packages.rootDir;


If I'm not mistaken - this is a breaking change for @changesets/apply-release-plan. This is fine - we just have to create a major changeset for it

Is it major? I might misunderstand the ramifications but I think apply-release-plan's external behavior for all existing monorepo implementations doesn't change (it's just a dependency bump + corresponding implementation tweak).

The problem is in the API surface - not the behavior. It now accepts an argument of a different shape

Andarist · 2023-01-27T20:44:30Z

Could we also add a test that would check changeset add and changeset version in Rush monorepos?

Andarist · 2023-01-31T08:50:47Z

        expect(await getCommitCount(clone)).toBeGreaterThan(5);
        expect(await getCommitCount(clone)).toBeLessThan(originalRepoDepth);
-      });
+      }, 10_000 /* 10 seconds */);


Hm, quite interesting that you are hitting timeouts here - somewhat similarly to what happened in manypkg repo. There is likely some overhead in spawn here but I never had problems with this - even on the older machine.

🤔 I wonder why... on the other repo, upgrading that ts wrapper tool made the timeout issues vanish.

But in this case, it's only this specific test that consistently goes over 5 seconds for me, and it's the test that calls git 50+ times so it made sense to me that it was a bit slower.

Out of curiosity - could you check how long those spawn('git', ...) calls take on your machine? It would be interesting to learn more about this particular bottleneck. This is, of course, just a sideways exploration - not quite related to this PR.

akphi · 2023-04-08T22:49:36Z

@elliot-nelson just curious, is this effort still being pursued?

Andarist · 2023-04-08T22:52:11Z

@akphi ye, definitely

elliot-nelson · 2023-04-09T22:56:09Z

Thanks for ping though looks like this is stalled on me 😅 I'll get those 2 additional tests added in next couple days.

akphi · 2023-07-19T16:39:13Z

@elliot-nelson did you have chance to look at this again?

danez · 2023-08-14T13:11:20Z

I think this will also fix this bug: #1209
I was investigating this and created more tests for manypkgs, but there it worked fine. Only then I realized changesets was using an old version.

What is left here? I cannot see the circleCI pipeline, so not sure what's broken. Can I somehow help get this over the finish line?

brad-mccormick · 2023-08-28T17:47:18Z

Anything we can do to help get this released? I'm at a standstill with a pnpm monorepo. @elliot-nelson

elliot-nelson · 2023-08-28T18:48:57Z

@Andarist 👋 Hi Andarist, long time no chat :). I've added tests that shows basic rush add and rush version commands working in a Rush-style monorepo with no root package file, and all existing tests for non-Rush repos should work as well.

lachlancollins · 2024-08-11T00:59:24Z

Hi @Andarist , I'm wondering if you could have a look at this old PR? The latest manypkg release cuts a bunch of dependencies.

@manypkg/get-packages@1.1.3 - 46 dependencies
@manypkg/get-packages@2.2.2 - 23 dependencies

bluwy · 2024-10-09T05:28:11Z

I know it's been a while, but if there's still interest in the PR, we've created a next branch to combine all the breaking changes, and perhaps this PR can be part of it too. Happy to leave a review too if so.

bluwy · 2025-11-18T02:08:37Z

There's now @manypkg/get-packages v3, which I upgraded in #1655 for the next branch. I've forgotten about this PR when I made that, but I'll make sure to reference this PR when I rebase mine and credit as co-author for any changes.

For now, I'll close this one, but thanks for contributing!

Update to latest version of manypkg

4d465fa

This was referenced Jan 27, 2023

[rush] Design: Changeset Integration and Changefile Spec microsoft/rushstack#3835

Open

fix: Support monorepos with no root package #1044

Closed

Andarist reviewed Jan 27, 2023

View reviewed changes

Add a test specifically for rush monorepos

78dffde

Andarist reviewed Jan 31, 2023

View reviewed changes

elliot-nelson added 4 commits August 28, 2023 14:31

Merge branch 'main' into enelson/major

0c9adc1

Merge latest and re-run testS

5e0585e

Add version command

8ae9679

Fix linting

07c516b

akphi mentioned this pull request Nov 20, 2024

relax parameters for read() #1517

Merged

bluwy closed this Nov 18, 2025

bluwy mentioned this pull request Nov 18, 2025

Update @manypkg/get-packages to v3 #1655

Merged

Conversation

elliot-nelson commented Jan 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

DETAILS

TESTING

Uh oh!

changeset-bot Bot commented Jan 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

codesandbox-ci Bot commented Jan 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Andarist commented Jan 27, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akphi commented Apr 8, 2023

Uh oh!

Andarist commented Apr 8, 2023

Uh oh!

elliot-nelson commented Apr 9, 2023

Uh oh!

akphi commented Jul 19, 2023

Uh oh!

danez commented Aug 14, 2023

Uh oh!

brad-mccormick commented Aug 28, 2023

Uh oh!

elliot-nelson commented Aug 28, 2023

Uh oh!

lachlancollins commented Aug 11, 2024

Uh oh!

bluwy commented Oct 9, 2024

Uh oh!

bluwy commented Nov 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

elliot-nelson commented Jan 27, 2023 •

edited

Loading

changeset-bot Bot commented Jan 27, 2023 •

edited

Loading

codesandbox-ci Bot commented Jan 27, 2023 •

edited

Loading