Skip to content

missing error handling for github API size limits #1715

@leekeh

Description

@leekeh

If you are requesting too many resources at once, the github API will return an error.

The response body will contain this:

<html>
<head><title>502 Bad Gateway</title></head>
<body>
<center><h1>502 Bad Gateway</h1></center>
<hr><center>nginx</center>
</body>
</html>

This will break the versioning, because response.json() will fail.

I think the cause is that the request data actually too large, possibly this is a limitation of graphQL.

I think we need two things:

  1. Handle non-json responses more gracefully, printing the API response body directly. In order to figure out what went wrong, I had to put breakpoints into the library manually.
  2. Have some way of handling an excess in commits, for example by splitting up the github API requests.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions