Update js-yaml to v4

marcalexiei · marcalexiei · commit 896cc5074fe9 · 2025-11-17T19:01:54.000+01:00
diff --git a/.changeset/tall-parks-worry.md b/.changeset/tall-parks-worry.md
@@ -0,0 +1,5 @@
+---
+"@changesets/parse": patch
+---
+
+Update `js-yaml` to `v4`
diff --git a/package.json b/package.json
@@ -43,7 +43,6 @@
     "@types/fs-extra": "^5.1.0",
     "@types/jest": "^24.0.12",
     "@types/jest-in-case": "^1.0.6",
-    "@types/js-yaml": "^3.12.1",
     "@types/lodash": "^4.17.13",
     "@types/node": "^22.14.1",
     "@types/prettier": "^2.7.1",
diff --git a/packages/parse/package.json b/packages/parse/package.json
@@ -20,9 +20,10 @@
   "repository": "https://github.com/changesets/changesets/tree/main/packages/parse",
   "dependencies": {
     "@changesets/types": "^6.1.0",
-    "js-yaml": "^3.13.1"
+    "js-yaml": "^4.1.1"
   },
   "devDependencies": {
+    "@types/js-yaml": "^4.0.9",
     "outdent": "^0.5.0"
   }
 }
diff --git a/packages/parse/src/index.test.ts b/packages/parse/src/index.test.ts
@@ -213,6 +213,20 @@ describe("parsing a changeset", () => {
       summary: "Nice simple summary",
     });
   });
+
+  it("should handle package name unquoted and version quoted", () => {
+    const changesetMd = `---
+    pkg: "minor"
+    ---
+
+    something`;
+    const changeset = parse(changesetMd);
+    expect(changeset).toEqual({
+      releases: [{ name: "pkg", type: "minor" }],
+      summary: "something",
+    });
+  });
+
   it("should throw if the frontmatter is followed by non-whitespace characters on the same line", () => {
     const changesetMd = outdent`---
     "cool-package": minor
@@ -229,4 +243,21 @@ describe("parsing a changeset", () => {
       Nice simple summary"
     `);
   });
+
+  it("should throw when frontmatter hasn't a valid yml structure", () => {
+    const changesetMd = outdent`---
+    : minor
+    ---
+
+    Nice simple summary
+    `;
+
+    expect(() => parse(changesetMd)).toThrowErrorMatchingInlineSnapshot(`
+      "could not parse changeset - invalid frontmatter: ---
+      : minor
+      ---
+
+      Nice simple summary"
+    `);
+  });
 });
diff --git a/packages/parse/src/index.ts b/packages/parse/src/index.ts
@@ -18,8 +18,10 @@ export default function parseChangesetFile(contents: string): {
 
   let releases: Release[];
   try {
-    const yamlStuff: { [key: string]: VersionType } =
-      yaml.safeLoad(roughReleases);
+    const yamlStuff = yaml.load(roughReleases) as
+      | Record<string, VersionType>
+      | undefined;
+
     if (yamlStuff) {
       releases = Object.entries(yamlStuff).map(([name, type]) => ({
         name,
diff --git a/yarn.lock b/yarn.lock
@@ -1777,10 +1777,10 @@
   dependencies:
     "@types/jest-diff" "*"
 
-"@types/js-yaml@^3.12.1":
-  version "3.12.1"
-  resolved "https://registry.yarnpkg.com/@types/js-yaml/-/js-yaml-3.12.1.tgz#5c6f4a1eabca84792fbd916f0cb40847f123c656"
-  integrity sha512-SGGAhXLHDx+PK4YLNcNGa6goPf9XRWQNAUUbffkwVGGXIxmDKWyGGL4inzq2sPmExu431Ekb9aEMn9BkPqEYFA==
+"@types/js-yaml@^4.0.9":
+  version "4.0.9"
+  resolved "https://registry.yarnpkg.com/@types/js-yaml/-/js-yaml-4.0.9.tgz#cd82382c4f902fed9691a2ed79ec68c5898af4c2"
+  integrity sha512-k4MGaQl5TGo/iipqb2UDG2UwjXziSWkh0uysQelTlJpX1qGlpUZYm8PnO4DxG1qBomtJUdYJ6qR6xdIah10JLg==
 
 "@types/json-schema@^7.0.9":
   version "7.0.11"
@@ -4614,6 +4614,13 @@ js-yaml@^4.1.0:
   dependencies:
     argparse "^2.0.1"
 
+js-yaml@^4.1.1:
+  version "4.1.1"
+  resolved "https://registry.yarnpkg.com/js-yaml/-/js-yaml-4.1.1.tgz#854c292467705b699476e1a2decc0c8a3458806b"
+  integrity sha512-qQKT4zQxXl8lLwBtHMWwaTcGfFOZviOJet3Oy/xmGk2gZH677CJM9EvtfdSkgWcATZhj/55JZ0rmy3myCT5lsA==
+  dependencies:
+    argparse "^2.0.1"
+
 jsesc@^3.0.2, jsesc@~3.0.2:
   version "3.0.2"
   resolved "https://registry.yarnpkg.com/jsesc/-/jsesc-3.0.2.tgz#bb8b09a6597ba426425f2e4a07245c3d00b9343e"

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@changesets/parse": patch
 +---
++
 +Update `js-yaml` to `v4`
Original file line number	Diff line number	Diff line change
`@@ -20,9 +20,10 @@`
`20`	`20`	`"repository": "https://github.com/changesets/changesets/tree/main/packages/parse",`
`21`	`21`	`"dependencies": {`
`22`	`22`	`"@changesets/types": "^6.1.0",`
`23`		`- "js-yaml": "^3.13.1"`
	`23`	`+ "js-yaml": "^4.1.1"`
`24`	`24`	`},`
`25`	`25`	`"devDependencies": {`
	`26`	`+ "@types/js-yaml": "^4.0.9",`
`26`	`27`	`"outdent": "^0.5.0"`
`27`	`28`	`}`
`28`	`29`	`}`