File tree Expand file tree Collapse file tree
assemble-release-plan/src Expand file tree Collapse file tree Original file line number Diff line number Diff line change 1+ ---
2+ " @changesets/assemble-release-plan " : patch
3+ " @changesets/cli " : patch
4+ ---
5+
6+ Fixed a crash in pre mode when trying to version private packages when tagging for private package is disabled
Original file line number Diff line number Diff line change @@ -361,7 +361,7 @@ function getPreInfo(
361361 if (
362362 shouldSkipPackage ( pkg , {
363363 ignore : config . ignore ,
364- allowPrivatePackages : config . privatePackages . tag ,
364+ allowPrivatePackages : config . privatePackages . version ,
365365 } )
366366 ) {
367367 continue ;
Original file line number Diff line number Diff line change @@ -3028,6 +3028,43 @@ describe("pre", () => {
30283028 ] ) ;
30293029 } ) ;
30303030
3031+ it ( "should version successfully a private package when tagging for them is disabled" , async ( ) => {
3032+ const cwd = await testdir ( {
3033+ "package.json" : JSON . stringify ( {
3034+ private : true ,
3035+ workspaces : [ "packages/*" ] ,
3036+ } ) ,
3037+ "packages/pkg-a/package.json" : JSON . stringify ( {
3038+ name : "pkg-a" ,
3039+ private : true ,
3040+ version : "1.0.0" ,
3041+ } ) ,
3042+ } ) ;
3043+ await pre ( cwd , { command : "enter" , tag : "next" } ) ;
3044+ await writeChangeset (
3045+ {
3046+ releases : [ { name : "pkg-a" , type : "patch" } ] ,
3047+ summary : "a very useful summary for the first change" ,
3048+ } ,
3049+ cwd
3050+ ) ;
3051+ await version ( cwd , defaultOptions , {
3052+ ...modifiedDefaultConfig ,
3053+ privatePackages : {
3054+ tag : false ,
3055+ version : true ,
3056+ } ,
3057+ } ) ;
3058+ let packages = ( await getPackages ( cwd ) ) ! ;
3059+ expect ( packages . packages . map ( ( x ) => x . packageJson ) ) . toEqual ( [
3060+ {
3061+ name : "pkg-a" ,
3062+ private : true ,
3063+ version : "1.0.1-next.0" ,
3064+ } ,
3065+ ] ) ;
3066+ } ) ;
3067+
30313068 describe ( "linked" , ( ) => {
30323069 it ( "should work with linked" , async ( ) => {
30333070 let linkedConfig = {
You can’t perform that action at this time.
0 commit comments