Less wrapper elements#18
Less wrapper elements#18chandlerprall merged 20 commits intochandlerprall:feature/virtualized-datagridfrom
Conversation
…rid' into flash1293/less-mutation-observers
chandlerprall
left a comment
There was a problem hiding this comment.
Wow, this is impressively faster. Thank you for looking into all of this!
Cell action should appear immediately on click
One thing we decided with cell actions is that they should appear immediately onFocus instead of being delayed like the popover button
Icon animations reset when expanding the popover
When clicking on the popover button, the cell actions hide and then re-animate in, they should stay present. This may be fixed for free with the previous item.
animation_reset.mov
|
Quick testing pass on the Data grid focus page:
|
|
Thanks for the detailed look @chandlerprall I addressed some issues, I'm not sure about these two:
Can we do an offline sync about those? |
|
@chandlerprall Fixed the problems discussed offline |
|
Additional changes look good, replied to the setState/noop thread. |
|
@flash1293 Here's a branch of a branch of a branch with some small fixes to this PR. |
fix prettier / ts issues
|
@chandlerprall Cleaned up remaining stuff, I think it's worth another look |
chandlerprall
left a comment
There was a problem hiding this comment.
thanks again @flash1293 !!
Based on #17
This PR reduces the number of wrapper elements per cell - as long as the cell is not hovered, there's just the regular cell element with one wrapper plus a hidden paragraph for screen reader a11y. This one last wrapper element is still in place because the CSS got pretty ugly otherwise and it didn't seem to have too much influence on performance.
This also prevents a double-render by waiting for the header row to get a height first before placing the data cells.
This also fixes a bug with
onMouseLeavewhich is not reliable, this PR solves it via css to only show the buttons in the cell is actually hovered.