No popover, no cell buttons#15
Merged
chandlerprall merged 5 commits intochandlerprall:feature/virtualized-datagridfrom Jan 26, 2021
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes sure cell popovers and cell buttons are only rendered if necessary to speed up the component.
To do so, the transition to fade in the buttons had to be replaced by animations (because it's hard to reliably kick off transitions as they require two render steps for new elements).
This PR includes a workaround for a bug in the popover component (popover isn't closable if it's rendered initially open) - if this problem is fixed, the additional flag
renderPopoverOpencan be removed because it's only used to add a closed popover component to the tree before opening it.