Drag and drop styles#14
Merged
chandlerprall merged 3 commits intochandlerprall:feature/markdown-editor-drag-n-dropfrom Jul 29, 2020
Merged
Conversation
…com/chandlerprall/eui into feature/markdown-editor-drag-n-drop
3 tasks
efefc77
into
chandlerprall:feature/markdown-editor-drag-n-drop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few inconsistencies across browsers.
The following code that starts on line 86 of the markdown_editor_drop_zone.tsx makes the drag and drop file not accepted don't work on Safari.
.euiMarkdownEditorDropZone--isDragging) would always appear. And then if a file was not accepted the footer error would appear. So having blue and that error in red makes more sense than green and red. So we just assume the blue as anisDraggingaction rather than success..euiMarkdownEditorDropZone--isDraggingErroris a red background and it disappears once we stop dragging an unaccepted file..euiMarkdownEditorDropZone--hasError'is the footer error and it stays there until we focus the textarea or try to upload/drag a new file.