[MERGE #4585 @rhuanjl] Remove useless setParent call and related condition.

boingoing · boingoing · commit 92c3acfd7ae1 · 2018-01-30T14:00:02.000-08:00
Merge pull request #4585 from rhuanjl:setparent Follow up to issue: #3638 The issue was already fixed by removing the unnecessary assert: #4548 But - it highlighted another small issue. The setParent call in JsrtCore is useless - it results in several operations all of which have no useful end result. (No test case included as this doesn't fix a bug it just removes useless code)
diff --git a/lib/Jsrt/Core/JsrtCore.cpp b/lib/Jsrt/Core/JsrtCore.cpp
@@ -27,10 +27,6 @@ JsInitializeModuleRecord(
         if (normalizedSpecifier != JS_INVALID_REFERENCE)
         {
             childModuleRecord->SetSpecifier(normalizedSpecifier);
-            if (Js::SourceTextModuleRecord::Is(referencingModule) && Js::JavascriptString::Is(normalizedSpecifier))
-            {
-                childModuleRecord->SetParent(Js::SourceTextModuleRecord::FromHost(referencingModule), Js::JavascriptString::FromVar(normalizedSpecifier)->GetSz());
-            }
         }
         return JsNoError;
     });

Original file line number	Diff line number	Diff line change
`@@ -27,10 +27,6 @@ JsInitializeModuleRecord(`
`27`	`27`	`if (normalizedSpecifier != JS_INVALID_REFERENCE)`
`28`	`28`	`{`
`29`	`29`	`childModuleRecord->SetSpecifier(normalizedSpecifier);`
`30`		`- if (Js::SourceTextModuleRecord::Is(referencingModule) && Js::JavascriptString::Is(normalizedSpecifier))`
`31`		`- {`
`32`		`- childModuleRecord->SetParent(Js::SourceTextModuleRecord::FromHost(referencingModule), Js::JavascriptString::FromVar(normalizedSpecifier)->GetSz());`
`33`		`- }`
`34`	`30`	`}`
`35`	`31`	`return JsNoError;`
`36`	`32`	`});`