Fix u128 RPC serialization/deserialization#307
Merged
koushiro merged 9 commits intodevelop-2.0from Oct 23, 2020
Merged
Conversation
Previously, the `Balance`, `Price` and `Weight` were serialized directly into u128 numbers in #238, but polkadot.js could not parse them successfully. Therefore, it is necessary to serialize `Balance`, `Price`, and `Weight` back to String. Unlike before, the serialization conversion of `Balance` and `Price` only occurs at the RPC layer and does not involve the types in the pallet (because the `Weight` is an alias of u128, so we use serde derive directly on the type to complete the serialization conversion). Signed-off-by: koushiro <koushiro.cqx@gmail.com>
liuchengxu
reviewed
Oct 23, 2020
liuchengxu
suggested changes
Oct 23, 2020
Contributor
liuchengxu
left a comment
There was a problem hiding this comment.
The Rust code looks good to me except the unnecessary trait renamings. Furthermore, chainx_types should be updated accordingly.
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
04947a3 to
2d08164
Compare
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
liuchengxu
reviewed
Oct 23, 2020
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
liuchengxu
approved these changes
Oct 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
Balance,PriceandWeightwere serialized directly into u128 numbersin #238, but polkadot.js could not parse them successfully.
Therefore, it is necessary to serialize
Balance,Price, andWeightback to String.Unlike before, the serialization conversion of
BalanceandPriceonly occurs at the RPC layer and does not involve the types in the pallet (because theWeightis an type alias of u128, so we use serde derive directly on the type to complete the serialization conversion).Signed-off-by: koushiro koushiro.cqx@gmail.com