Skip to content
This repository was archived by the owner on Feb 6, 2023. It is now read-only.

Skip chainer tests for CuPy v8#585

Merged
asi1024 merged 2 commits intochainer:masterfrom
kmaehashi:skip-chainer-test-correctly
Jul 3, 2020
Merged

Skip chainer tests for CuPy v8#585
asi1024 merged 2 commits intochainer:masterfrom
kmaehashi:skip-chainer-test-correctly

Conversation

@kmaehashi
Copy link
Copy Markdown
Member

@kmaehashi kmaehashi commented Jul 3, 2020

Fix made in #584 was wrongly testing JOB_NAME.
By this configuration change #583 (comment) we no longer use CuPy v8 in chainer-* variations in chainer-test_pr, so JOB_NAME condition is not necessary anymore.

@kmaehashi kmaehashi force-pushed the skip-chainer-test-correctly branch from 5bc99f3 to dfd4c32 Compare July 3, 2020 16:12
@kmaehashi
Copy link
Copy Markdown
Member Author

pfnCI, test this please.

@chainer-ci
Copy link
Copy Markdown
Member

Jenkins CI test (for commit 72dc7c1, target branch master) succeeded!

@asi1024
Copy link
Copy Markdown
Member

asi1024 commented Jul 3, 2020

LGTM.

@asi1024 asi1024 merged commit 71d02a3 into chainer:master Jul 3, 2020
@kmaehashi kmaehashi deleted the skip-chainer-test-correctly branch July 4, 2020 05:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants