This repository was archived by the owner on Feb 6, 2023. It is now read-only.
Tentatively remove sentiment example test#532
Merged
hvy merged 2 commits intochainer:masterfrom Oct 9, 2019
Merged
Conversation
13 tasks
Member
|
Should we also comment out the example in https://github.com/chainer/chainer-test/blob/master/test_prev_example.sh in this PR too? |
Member
Author
|
Thanks, fixed |
Member
|
Thanks, LGTM! |
Member
|
Jenkins, test this please. |
Member
|
Jenkins CI test (for commit ad03d09, target branch master) succeeded! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLS cert of the server that hosts example dataset expired today. https://nlp.stanford.edu/sentiment/
Tentatively remove the test.
If the situation does not change for a week, let's consider an alternate solution.